-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS 274 Remove bolt dropdown component #2365
DS 274 Remove bolt dropdown component #2365
Conversation
…urls, microjurneys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr looks good. Ready to approve once you address my comment about the ssr-server file. Thanks!
Also, I updated this branch with the latest from feature/bolt-5-0
to fix the failing Travis build. It needed the new chromedriver.
@@ -135,9 +134,6 @@ async function setupWebpack(config) { | |||
}); | |||
} | |||
}); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr why were these lines below removed? They don't seem to be related to dropdown.
This whole ssr-server package is unused to it's no big deal, but if these weren't intentionally removed let's revert this part of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I couldn't remind myself how and why I removed those lines of code... I tried to restore it but every time I save the file, the code removes itself. I checked on a master and it happens either for that file. It looks like this:
the code is grayed out a littlebit
and when I hover over it, there is an info msg that the code is unreachable
Quick fix
proposes deleting that code.
Could you please explain why it happens and how can we solve it?
Here is how it behaves on save:
https://user-images.githubusercontent.com/85670248/138850146-7d2f93f0-8119-4ef0-b39d-de95f0aac9c1.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. It is in fact unreachable code and VS Code is automatically removing it.
Anything after a return statement will not run. For example:
myFunctionA() {
console.log('this will run');
return 'foo';
console.log('this will never run');
}
myFunctionB() {
if (option) {
return 'foo';
}
console.log('this will run only if `option` is falsy');
}
In this file, there is a return statement above the lines you removed, so these lines will never run.
This is fine to remove in this PR 👍
Jira
https://pegadigitalit.atlassian.net/browse/DS-274
Summary
The dropdown component is removed completely.
Details
bolt-dropdown
component in the GitLab.packages
anddoc-site
.How to test
Check if there are no instances of dropdown components and if was deleted properly without regressions.
Release notes
The dropdown component is removed.