Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Yarn error and misplaced icons #2381

Merged
merged 3 commits into from Nov 12, 2021

Conversation

danielamorse
Copy link
Collaborator

@danielamorse danielamorse commented Nov 10, 2021

Jira

n/a

Summary

Fixes yarn error and misplaced icons.

Details

Yarn error

@bolt/testing-utils was not incremented from v4 to v5 in the v5.0.0 release and it triggers a yarn error when you try to install the site locally. The error is related to having multiple versions of some dependency and yarn not being able to properly resolve it:

error An unexpected error occurred: "expected workspace package to exist for \"glob-parent\"".

glob-parent I suspect is a dependency of a dependency of @bolt/testing-utils. Incrementing to v5 fixes it.

This error does not seem to happen on yarn 1.19.x, which is the version Travis runs on. It was only caught locally where most of us run 1.22.x.

Perhaps we could lock Travis to 1.22.x to catch this in the future. Or, we ignore for now and upgrade to Yarn 2 in the next build which doesn't seem to experience this error (I'm leaning towards the latter).

Misplaced icons

In #2301 some icons were reverted. When we merged in newer icon updates we did not resolve these reverted icons which now appeared in the wrong directory. This PR moves them where they belong.

How to test

  • Run yarn clean, yarn setup, and yarn start to verify PL builds as expected
  • Verify new icons have been added back and appear as expected in the Icon Element docs

@github-actions github-actions bot added the version: patch Use only on PRs to the release branch. Increments the patch version when merged. label Nov 10, 2021
@colbytcook colbytcook had a problem deploying to hotfix/yarn-error-and-icons--1bd412ee--commit-preview November 11, 2021 00:40 Failure
@colbytcook colbytcook merged commit e45c654 into release/5.x Nov 12, 2021
@colbytcook colbytcook deleted the hotfix/yarn-error-and-icons branch November 12, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: patch Use only on PRs to the release branch. Increments the patch version when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants