Hotfix: Yarn error and misplaced icons #2381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
n/a
Summary
Fixes yarn error and misplaced icons.
Details
Yarn error
@bolt/testing-utils
was not incremented from v4 to v5 in the v5.0.0 release and it triggers a yarn error when you try to install the site locally. The error is related to having multiple versions of some dependency and yarn not being able to properly resolve it:glob-parent
I suspect is a dependency of a dependency of@bolt/testing-utils
. Incrementing to v5 fixes it.This error does not seem to happen on yarn 1.19.x, which is the version Travis runs on. It was only caught locally where most of us run 1.22.x.
Misplaced icons
In #2301 some icons were reverted. When we merged in newer icon updates we did not resolve these reverted icons which now appeared in the wrong directory. This PR moves them where they belong.
How to test
yarn clean
,yarn setup
, andyarn start
to verify PL builds as expected