Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-679 Profile view #2383

Merged
merged 27 commits into from
Nov 18, 2021
Merged

DS-679 Profile view #2383

merged 27 commits into from
Nov 18, 2021

Conversation

mikemai2awesome
Copy link
Collaborator

@mikemai2awesome mikemai2awesome commented Nov 13, 2021

Jira

https://pegadigitalit.atlassian.net/browse/DS-679

Spawned from: https://pegadigitalit.atlassian.net/browse/DS-590

Summary

Added Profile and Info Section components.

Details

  1. Profile component created to handle user profiles
  2. Info Section component created to handle sections within a user profile
  3. Removes text-align behaviors in Tooltip component to simplify the code and make the behavior more predictable
  4. Misc. docs changes that enhance or re-organize existing docs
  5. Fixes Image element CSS so that when fill prop is used, the image's display is set to block, which removes undesired white space from inline-block

How to test

Run the branch locally and check the Profile and Info Section component docs. There's also a Profile View demo under Pages > User > User Profile, Drupal devs will use this mockup to build out the page. Review it as well.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Nov 13, 2021
@colbytcook colbytcook temporarily deployed to feature/ds-590-profile-view--branch-preview November 13, 2021 04:43 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-profile-view--branch-preview November 13, 2021 07:40 Inactive
@mikemai2awesome mikemai2awesome changed the title [DO NOT MERGE] DS-590 Profile view DS-590 Profile view Nov 15, 2021
@mikemai2awesome mikemai2awesome changed the title DS-590 Profile view DS-679 Profile view Nov 15, 2021
@mikemai2awesome
Copy link
Collaborator Author

@danielamorse Need JS help with the Info Section component, convert the JS in index.js to be production ready in info-section.js.

const infoSectionToggleButtons = document.querySelectorAll(
  '.js-bolt-info-section-toggle-button',
);

infoSectionToggleButtons.forEach(button => {
  button.addEventListener('click', e => {
    const el = e.target;
    const isExpanded = el.getAttribute('aria-expanded') === 'true';
    const otherButtons = [...infoSectionToggleButtons].filter(
      button => button !== el,
    );

    if (isExpanded) {
      el.setAttribute('aria-expanded', false);
    } else {
      otherButtons.forEach(el => {
        el.setAttribute('aria-expanded', false);
      });
      el.setAttribute('aria-expanded', true);
    }
  });
});

@colbytcook colbytcook requested a deployment to feature/ds-590-profile-view--75c1630--commit-preview November 15, 2021 22:55 In progress
@colbytcook colbytcook temporarily deployed to feature/ds-590-profile-view--branch-preview November 16, 2021 22:00 Inactive
@colbytcook colbytcook requested a deployment to feature/ds-590-profile-view--branch-preview November 16, 2021 22:04 Abandoned
@colbytcook colbytcook had a problem deploying to feature/ds-590-profile-view--branch-preview November 17, 2021 23:10 Failure
@colbytcook colbytcook requested a deployment to feature/DS-677-Notifications-tag-manager--b704bcc--commit-preview November 17, 2021 23:50 In progress
@colbytcook colbytcook temporarily deployed to feature/ds-590-profile-view--branch-preview November 18, 2021 15:37 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-profile-view--branch-preview November 18, 2021 16:55 Inactive
@colbytcook colbytcook requested a deployment to feature/ds-590-profile-view--255d010--commit-preview November 18, 2021 16:59 In progress
@colbytcook colbytcook self-requested a review November 18, 2021 17:02
@colbytcook colbytcook requested a deployment to feature/DS-622-build-hero-with-layout--0559a1ff--commit-preview November 18, 2021 17:30 In progress
@danielamorse danielamorse merged commit 2081dbc into master Nov 18, 2021
@danielamorse danielamorse deleted the feature/ds-590-profile-view branch November 18, 2021 17:48
danielamorse added a commit that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants