-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-679 Profile view #2383
Merged
Merged
DS-679 Profile view #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielamorse Need JS help with the Info Section component, convert the JS in
|
danielamorse
approved these changes
Nov 17, 2021
remydenton
requested changes
Nov 17, 2021
docs-site/src/pages/pattern-lab/_patterns/40-components/profile/10-profile-full-bleed.twig
Show resolved
Hide resolved
colbytcook
reviewed
Nov 18, 2021
colbytcook
reviewed
Nov 18, 2021
remydenton
reviewed
Nov 18, 2021
remydenton
approved these changes
Nov 18, 2021
colbytcook
approved these changes
Nov 18, 2021
danielamorse
added a commit
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-679
Spawned from: https://pegadigitalit.atlassian.net/browse/DS-590
Summary
Added Profile and Info Section components.
Details
fill
prop is used, the image's display is set to block, which removes undesired white space from inline-blockHow to test
Run the branch locally and check the Profile and Info Section component docs. There's also a Profile View demo under Pages > User > User Profile, Drupal devs will use this mockup to build out the page. Review it as well.