DS-590 Notifications component #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbytcook
temporarily deployed
to
feature/ds-590-notifications-component--branch-preview
colbytcook
had a problem deploying
to
feature/ds-590-notifications-component--branch-preview
There was a problem hiding this comment.
@mikemai2awesome the static demos are looking 💅
I left a few comments, only one is a blocker to merging: #2392 (comment)
packages/components/bolt-notifications/notifications-list-item.schema.js
Show resolved
Hide resolved
colbytcook
temporarily deployed
to
feature/ds-590-notifications-component--branch-preview
|
Approved, updated tests. I will merge once this passes. |
colbytcook
had a problem deploying
to
feature/ds-590-notifications-component--branch-preview
colbytcook
requested a deployment
to
feature/ds-590-page-header-notifications--1ba3f762--commit-preview
danielamorse
approved these changes
Dec 8, 2021
remydenton
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
This all checks out, thanks @mikemai2awesome .
Just an aside, it is hard to look at this schema and know how things are supposed to be assembled, i.e. what belongs inside what. The only way is to look at the examples.
I don't have any brilliant solutions, just something to think about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-590
Summary
Adds a Notifications component to display user notifications.
Details
onprop to follow conventions. Boolean props default tofalse.How to test
Run the branch locally and check the Notifications docs. Make sure all props work as expected.