Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background Component LazyLoad Update #2394

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Background Component LazyLoad Update #2394

merged 1 commit into from
Dec 7, 2021

Conversation

colbytcook
Copy link
Contributor

Summary

Updated the Bolt Background lazy load conditional to default to lazy

How to test

  1. Pull down the branch locally
  2. Navigate to http://localhost:3000/pattern-lab/?p=pages-d8-homepage
  3. Inspect the Bolt Background image and confirm that loading="eager" is present
  4. Change the twig value on line 107 in "docs-site/src/pages/pattern-lab/_patterns/50-pages/05-d8-homepage/00-d8-homepage.twig" to "true"
  5. Reload the page http://localhost:3000/pattern-lab/?p=pages-d8-homepage
  6. Inspect the Bolt Background image and confirm that loading="lazy" is present

@github-actions github-actions bot added the type: bugfix List this PR in the 'Bug Fixes' section of the release notes. label Dec 6, 2021
@colbytcook colbytcook mentioned this pull request Dec 7, 2021
Merged
@colbytcook colbytcook mentioned this pull request Dec 7, 2021
Closed
@colbytcook colbytcook merged commit 03c3933 into master Dec 7, 2021
@colbytcook colbytcook deleted the bugfix/background-image-update branch December 7, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielamorse danielamorse danielamorse approved these changes

@remydenton remydenton remydenton approved these changes

@mikemai2awesome mikemai2awesome mikemai2awesome approved these changes

Assignees
No one assigned
Labels
type: bugfix List this PR in the 'Bug Fixes' section of the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colbytcook @danielamorse @remydenton @mikemai2awesome @bolt-bot