Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-660 Ratio Element #2400

Merged
merged 61 commits into from
Dec 17, 2021
Merged

DS-660 Ratio Element #2400

merged 61 commits into from
Dec 17, 2021

Conversation

MarcinMr
Copy link
Collaborator

@MarcinMr MarcinMr commented Dec 8, 2021

Jira

https://pegadigitalit.atlassian.net/browse/DS-660

Summary

Ratio Element is created to replace the Ratio Component in the future.

Details

A new Ratio Element was created and its docs

  • schema
  • twig template
  • scss
  • docs

How to test

Pull the branch. Check if:

  • the schema is compatible with our standards
  • styles are efficient and sufficient for this element
  • ratio element meets use cases and can replace the old ratio component
  • docs are useful and readable

Release notes

Ratio Component will be deprecated and replaced with the new Ratio Element.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Dec 8, 2021
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 8, 2021 15:34 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 14, 2021 22:08 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 14, 2021 22:46 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 14, 2021 23:24 Inactive
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcinMr As we discussed in dev huddle, we decided to remove the doc page about nearest aspect ratio since it might create confusion rather than providing useful tips.

I also added a doc page demonstrating image fit and position within ratio, those are expected to work. This was brought up in huddle by @adamszalapski .

I'll leave it to you to resolve the merge conflicts. This is all set from me.

@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 15, 2021 18:38 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 15, 2021 19:16 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 16, 2021 08:46 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-660-ratio-element--branch-preview December 16, 2021 11:18 Inactive
@MarcinMr
Copy link
Collaborator Author

@mikemai2awesome thanks for the updates. Solved conflict related to a cache

Copy link
Contributor

@colbytcook colbytcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. One note to make on using this in prod. Safari 15 for both OS and iOS support this feature but unfortunately Safari Mobile still has a significant user base (9.62% global usage). It is only a matter of time until this number drops but until then we probably shouldn't be using this element on production (yet). If we see the user base drop under 2% globally then we should be good to update the docs and components to leverage this (I will create tickets to deprecate the ratio component and update the docs and components with the ratio element).

Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and got a visual demo last week.

@danielamorse danielamorse merged commit e964875 into master Dec 17, 2021
@danielamorse danielamorse deleted the feature/DS-660-ratio-element branch December 17, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants