-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-660 Ratio Element #2400
DS-660 Ratio Element #2400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr As we discussed in dev huddle, we decided to remove the doc page about nearest aspect ratio since it might create confusion rather than providing useful tips.
I also added a doc page demonstrating image fit and position within ratio, those are expected to work. This was brought up in huddle by @adamszalapski .
I'll leave it to you to resolve the merge conflicts. This is all set from me.
@mikemai2awesome thanks for the updates. Solved conflict related to a cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. One note to make on using this in prod. Safari 15 for both OS and iOS support this feature but unfortunately Safari Mobile still has a significant user base (9.62% global usage). It is only a matter of time until this number drops but until then we probably shouldn't be using this element on production (yet). If we see the user base drop under 2% globally then we should be good to update the docs and components to leverage this (I will create tickets to deprecate the ratio component and update the docs and components with the ratio element).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and got a visual demo last week.
Jira
https://pegadigitalit.atlassian.net/browse/DS-660
Summary
Ratio Element is created to replace the Ratio Component in the future.
Details
A new Ratio Element was created and its docs
How to test
Pull the branch. Check if:
schema
is compatible with our standardsstyles
are efficient and sufficient for this elementratio element
meets use cases and can replace the oldratio component
docs
are useful and readableRelease notes
Ratio Component
will be deprecated and replaced with the newRatio Element
.