DOCS-232 Fix holy grail layout content width #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
colbytcook
approved these changes
Dec 13, 2021
danielamorse
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
@mikemai2awesome looks good, works as expected.
Should we add a comment here about why we use minmax() instead of just 1fr?
colbytcook
had a problem deploying
to
bugfix/docs-232-holy-grail-content-width--eeb2aece--commit-preview
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DOCS-232
Summary
Fixes a grid width issue with the Holy Grail Layout that causes responsive tables to not render correctly.
Details
Use
1frin CSS grid template is causing certain components miscalculate the width of its parent container. It has been changed tominmax(0, 1fr)as a fix. 0 min-width straightens out the issue.How to test
Run the branch locally and check the Holy Grail Layout docs. The table in the use case demo should be able to horizontally scroll when the viewport is smaller than ~1000px.