JS refactoring #2408
Merged
JS refactoring #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/prod-dropdown-cleanup--edits--branch-preview
colbytcook
temporarily deployed
to
feature/prod-dropdown-cleanup--edits--branch-preview
colbytcook
reviewed
Dec 20, 2021
| let versionSpinner; | ||
|
|
||
| const { getConfig } = require('@bolt/build-utils/config-store'); | ||
| const { fileExists } = require('@bolt/build-utils/general'); | ||
| const lernaConfig = require('./../../../../lerna.json'); | ||
| const lernaConfig = require(path.join(process.cwd(), '../lerna.json')); |
There was a problem hiding this comment.
@danielamorse I should I mentioned this but the path.join fails depending on what command is run. the ../ works on yarn start but fails on yarn build (I think) due the directory changing to be the parent folder of the Bolt repository. We might want to turn this back the ugly relative link.
Edit: the command that fails is the yarn test:js
There was a problem hiding this comment.
Makes sense. I reverted my change.
colbytcook
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
n/a
Summary
Refactors some JS in #2406.
Details
semver-comparedependency. Thesemverpackage we already use has a function for comparing.lerna.jsonusingprocess.cwd()rather than relative path from package.