-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WWW-1157: iOS modal bug #2414
WWW-1157: iOS modal bug #2414
Conversation
…al, updated the modal CSS for more conistent behavior
docs-site/src/pages/pattern-lab/_patterns/999-tests/table/00-table-modal.twig
Outdated
Show resolved
Hide resolved
packages/global/styles/07-utilities/_utilities-ios-content-fill.scss
Outdated
Show resolved
Hide resolved
packages/global/styles/07-utilities/_utilities-ios-content-fill.scss
Outdated
Show resolved
Hide resolved
packages/global/styles/07-utilities/_utilities-ios-content-fill.scss
Outdated
Show resolved
Hide resolved
packages/global/styles/07-utilities/_utilities-ios-content-fill.scss
Outdated
Show resolved
Hide resolved
packages/global/styles/07-utilities/_utilities-ios-content-fill.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. But feels weird to use a component class on the body, thoughts, @danielamorse?
…or the iOS fix and removed a unneeded tesst page
@danielamorse I updated this PR based on our conversation, the color overlay is now scoped to the @mikemai2awesome please take a look at the update modal docs and let me know if you have any suggestions on improving them (I based the UI on the elements page structure). |
docs-site/src/pages/pattern-lab/_patterns/40-components/modal/25-modal-scroll-variations.twig
Show resolved
Hide resolved
docs-site/src/pages/pattern-lab/_patterns/40-components/modal/30-modal-trigger-variations.twig
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemai2awesome @colbytcook updated the CSS to leverage the existing overlay, see commit.
Jira
https://pegadigitalit.atlassian.net/browse/WWW-1157
https://pegadigitalit.atlassian.net/browse/DS-448
Summary
Added a new utility class to help solve a iOS scroll bug with the modal, updated the modal CSS for more consistent behavior
Details
How to test
Pull down the branch and complete the following tasks.
Non-iOS Devices
iOS Devices (either an iPhone or an iPhone emulator)
Visual changes
On iOS Safari there will now be a navy blue background behind the modal, this can only be seen by having thee URL bar at the bottom of the screen and scrolling up (the URL bar should disappear off the bottom of the screen). If the URL bar hides these will be a navy blue color between the bottom of the modal and the bottom of thee view port.