DS-695 Comment-out content-visibility rule #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
mikemai2awesome
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-695
Summary
content-visibility: auto;is conflicting with our JS that calculates scroll position. Comment-out to avoid bugs until we can fix the root issue.Details
When an image is far enough outside of the viewport,
content-visibility: auto;will hide the image and the height thereafter is determined by theheightattribute of the image. If there is noheightattribute, the height is0. Either way, this change in height can happen while the TOC is in mid-scroll toward a target section. Upon arrival at that section, the page has shifted and it arrives at the wrong spot. Until we can figure out how to work with this new property, I am commenting-out this rule.How to test
Review files changed. Nothing else to review.