DS-697 Prevent Listing teaser from outputting empty div #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
colbytcook
requested a deployment
to
feature/DS-692-animation-tool-set--a1276d2a--commit-preview
|
@danielamorse template updated |
danielamorse
approved these changes
Jan 20, 2022
mikemai2awesome
approved these changes
Jan 20, 2022
danielamorse
deleted the
feature/DS-697-Prevent-Listing-teaser-from-outputting-empty-div
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-697
Summary
The if conditional was added to prevent rendering empty div -
c-bolt-listing-teaser__flag-contentDetails
c-bolt-listing-teaser__flag-contentis rendered if one of the following properties is added:meta_itemsdescriptionwarningchip_listreplyHow to test
Check if div with the class
c-bolt-listing-teaser__flag-contentis rendered only when one or more properties are added