Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WWW-1217 add open prop to page footer nav list #2420

Merged
merged 2 commits into from
Jan 24, 2022
Merged

WWW-1217 add open prop to page footer nav list #2420

merged 2 commits into from
Jan 24, 2022

Conversation

mikemai2awesome
Copy link
Collaborator

@mikemai2awesome mikemai2awesome commented Jan 19, 2022 •
edited

Jira

https://pegadigitalit.atlassian.net/browse/WWW-1215
https://pegadigitalit.atlassian.net/browse/WWW-1217

Summary

Adds a open prop to Page Footer's nav list template.

Details

  1. Updated twig and schema.
  2. The prop will make a nav list expand by default in mobile view.

How to test

Run the branch locally and check the Page Footer docs, make sure the open prop works as expected.

@github-actions github-actions bot added the version: patch Use only on PRs to the release branch. Increments the patch version when merged. label Jan 19, 2022
@mikemai2awesome mikemai2awesome changed the base branch from master to release/5.x January 19, 2022 16:33
@mikemai2awesome mikemai2awesome changed the title www-1215: add open prop to page footer nav list WWW-1215 add open prop to page footer nav list Jan 19, 2022
@colbytcook colbytcook requested a deployment to hotfix/www-1215-footer-nav-list-open--branch-preview January 19, 2022 16:52 In progress
@colbytcook colbytcook temporarily deployed to hotfix/www-1215-footer-nav-list-open--branch-preview January 19, 2022 17:05 Inactive
@remydenton remydenton changed the title WWW-1215 add open prop to page footer nav list WWW-1231 add open prop to page footer nav list Jan 24, 2022
@remydenton remydenton changed the title WWW-1231 add open prop to page footer nav list WWW-1217 add open prop to page footer nav list Jan 24, 2022
@remydenton remydenton added type: feature List this PR in the 'Features' section of the release notes. and removed version: patch Use only on PRs to the release branch. Increments the patch version when merged. labels Jan 24, 2022
@remydenton remydenton changed the base branch from release/5.x to master January 24, 2022 19:29
@remydenton
Copy link
Collaborator

Note, I changed this from a hotfix to a regular PR since the 5.2 release is imminent. CC @danielamorse

@remydenton remydenton merged commit b3e6741 into master Jan 24, 2022
@remydenton remydenton deleted the hotfix/www-1215-footer-nav-list-open branch January 24, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remydenton remydenton remydenton approved these changes

Assignees
No one assigned
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikemai2awesome @remydenton @colbytcook