-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-699 Safari Image Position Bug #2422
Conversation
…operty set to auto
…t to auto and viewport is below the image's given max-width
Here https://boltdesignsystem.com/pattern-lab/?p=components-modal-trigger-variations is written that: "Advanced usage: if the Image component has an absolute value (e.g. 640px) defined for But this didn't work well and the image wasn't responsive below its image.modal.unresponsive.movI added the Just curious, do we have/use user-agent classes depending on what browser the user has? Wouldn't it be good to fix bugs related to the browser? Because sometimes fixing something on one browser can break things on another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr I reverted some of your CSS, the docs are outdated. All images must have width and height attributes defined, this will ensure they display correctly.
I also fixed some of the docs to be more clear.
Jira
https://pegadigitalit.atlassian.net/browse/DS-699
Summary
An image center position on Safari was fixed
Details
When
max-width: value;
inline style is applied to an<img>
and modal width property is set toauto
, the image should stay in the center position.How to test
Pull the branch. Add an inline style to an image for example
max-width: 600px
and set the modal width toauto
, Check if modal width adjusts to the image width and the image stays in the center position.