Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-541 Floating Action Buttons #2423

Merged
merged 75 commits into from
Apr 15, 2022

Conversation

cjwhitedev
Copy link
Collaborator

@cjwhitedev cjwhitedev commented Jan 21, 2022

Jira

Summary

Create a component for floating action buttons.

Details

  1. Added the new Floating Action Buttons component
  2. Created full page demos to showcase the component usage
  3. Fixed a bug in Button element where icon is way too big for small icon-only buttons

How to test

  1. Pull Down the Branch and update.
  2. Check out the demo pages.

Release notes

New component named Floating Action Buttons added.

Visual changes

Icon-only button with size set to small renders smaller icon now. Overall button size is not affected.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Jan 21, 2022
@cjwhitedev cjwhitedev changed the title Feature/ds 541 floating action buttons DS-541 floating action buttons Jan 21, 2022
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview January 21, 2022 16:43 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview January 21, 2022 17:22 Inactive
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwhitedev This is a good first pass. First, let's keep this simple and just name this Floating Action Buttons rather than a fancy term that doesn't resonate.

Secondly, let's go over some visual enhancements and semantics fixes.

Visual

Let's create some information hierarchy here. If the more button toggles on additional buttons, these would be considered secondary. Rough sketch below:

fab

Additionally, it'd be great to smooth out the transition with some motion effects like this.

Semantics

This is a list of buttons, let's apply the correct semantics in the markup.

<ul>
  <li>
    <button type="button">more</button>
    <ul>
      <li>
        <a href="">
          rocket
        </a>
      </li>
      <li>
        <a href="">
          rocket
        </a>
      </li>
      <li>
        <a href="">
          rocket
        </a>
      </li>
    </ul>
  </li>
  <li>
    <a href="">share</a>
  </li>
  <li>
    <a href="">scroll to top</a>
  </li>
</ul>

packages/components/bolt-satellite/satellite.schema.js Outdated Show resolved Hide resolved
@colbytcook colbytcook had a problem deploying to feature/DS-541-floating-action-buttons--branch-preview January 27, 2022 18:00 Failure
@colbytcook colbytcook requested a deployment to feature/DS-541-floating-action-buttons--branch-preview January 27, 2022 18:04 Abandoned
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview January 28, 2022 17:00 Inactive
@colbytcook colbytcook requested a deployment to feature/DS-541-floating-action-buttons--branch-preview January 28, 2022 17:04 Abandoned
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview January 28, 2022 19:31 Inactive
@colbytcook colbytcook had a problem deploying to feature/DS-541-floating-action-buttons--branch-preview January 28, 2022 20:03 Failure
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview April 4, 2022 18:30 Inactive
@colbytcook colbytcook requested a deployment to feature/DS-541-floating-action-buttons--fa2d63cd--commit-preview April 5, 2022 17:47 In progress
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview April 5, 2022 17:51 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwhitedev left a few inline requests. Please also update demo titles and description to reflect the new prop name (still see examples of "show-on-scroll-position"), and remember to prefix commit messages with the ticket number 🙏

@colbytcook colbytcook had a problem deploying to feature/ds-744-refine-table-colors--branch-preview April 11, 2022 17:01 Failure
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview April 11, 2022 17:06 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview April 11, 2022 17:42 Inactive
@danielamorse danielamorse self-requested a review April 15, 2022 13:26
@colbytcook colbytcook temporarily deployed to feature/DS-541-floating-action-buttons--branch-preview April 15, 2022 13:44 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwhitedev approved! 🎉 Thanks for sticking with this one. I think it turned out great.

I made two last tweaks. One is a very minor JS style thing - I tend to skip brackets for single-line if statement. It's totally fine to include brackets (some prefer that), but for consistency I removed them (see commit). Second, I removed the remaining scroll-position demos (see commit).

Before merging I just want to double-check this has @mikemai2awesome's approval. I think he approved before many recent changes.

Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielamorse @cjwhitedev I fixed some docs and tested with screen readers. Good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants