Fix: add max width to regular modal #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
danielamorse
approved these changes
Feb 4, 2022
danielamorse
added a commit
that referenced
this pull request
Feb 4, 2022
…ax-width Fix: add max width to regular modal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a max-width to regular modals.
Details
regularoption for Modal component's width propHow to test
Run the branch locally and check the modal docs. Modals with width set to
regularshould be no wider than 1400px.Release notes
Visual changes
Any modal that has
widthset toregularnow has a max-width of 1400px. This means the modal width will not get wider than 1400px. For modals that require going beyond that max-width, usewidth: fullinstead.