Fix: page header pulse icon link for Saleshub #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
version: patch
colbytcook
requested a deployment
to
hotfix/page-header-saleshub-pulse-link--9009b50--commit-preview
colbytcook
requested a deployment
to
feature/DS-541-floating-action-buttons--f19e92f8--commit-preview
remydenton
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where signifier only links in the Page Header's utility nav is mis-aligned.
Details
Updated twig and css to accommodate signifier only links that don't have children.
How to test
Run the branch locally and check the Saleshub page header demo. Make sure the Pulse link in page header is an icon only link without children. When hover or tab to, a tooltip shows the word "pulse".