DS-737 multi-column form layout and grid spacing fix #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/ds-737-two-column-form-layout--branch-preview
colbytcook
requested a deployment
to
feature/DS-630-header-screenreader-use--e5322bb9--commit-preview
colbytcook
requested a deployment
to
feature/ds-737-two-column-form-layout--branch-preview
mikemai2awesome
changed the title
mikemai2awesome
changed the title
colbytcook
temporarily deployed
to
feature/ds-737-two-column-form-layout--branch-preview
colbytcook
temporarily deployed
to
feature/ds-737-two-column-form-layout--branch-preview
colbytcook
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
@mikemai2awesome the demo looks good.
I assume it's safe to remove display "block" and not break existing grid layouts?
I do see schema errors on the demo page. Do you know what that's all about?
colbytcook
temporarily deployed
to
feature/ds-737-two-column-form-layout--branch-preview
colbytcook
temporarily deployed
to
feature/ds-737-two-column-form-layout--branch-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-737
Summary
Fixed grid spacing issues and added a multi-column form layout demo.
Details
How to test
Run the branch locally and check the Grid docs and the "Demo: Multi-column Form" under the Form docs.