DS-745 Support PHP 8 #2454
Merged
DS-745 Support PHP 8 #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are temporary-- if all works as expected, we should merge the changes on the bolt fork of basaltinc/twig-tools into master.
github-actions
bot
added
the
type: feature
colbytcook
had a problem deploying
to
feature/DS-745-support-php-8--branch-preview
|
The changes looked good and made sense to me. Unfortunately, it looks like there is a build error. |
andrewmriv
approved these changes
Mar 19, 2022
Image color is now hard-coded.
colbytcook
had a problem deploying
to
feature/DS-745-support-php-8--branch-preview
It's not clear to me which faker usage instances caused problems during build and which didn't. PL builds normally locally with these changes but not without them, so hopefully this is sufficient.
colbytcook
requested a deployment
to
feature/DS-541-floating-action-buttons--f3e0f767--commit-preview
|
@remydenton This looks good to me. Agree it's a good time to remove these libraries. I noticed there are some instances of |
colbytcook
temporarily deployed
to
feature/DS-745-support-php-8--branch-preview
colbytcook
requested a deployment
to
bugfix/typeahead-button-position--0ffe8fa4--commit-preview
|
Thanks for the reviews guys. @danielamorse, as discussed on Slack I went ahead and removed the remaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-745
Summary
Removes dependency on two composer packages that are incompatible with PHP 8
Details
This PR removes the following two dependencies, which are incompatible with PHP 8 and abandoned:
For faker, I also had to remove it as a sub dependency of our fork of
basaltinc/twig-tools: boltdesignsystem/twig-tools#2. We should first merge that PR, then update this PR to use the master branch before merging it.How to test
Confirm no regressions on this branch. Confirm that faker text has been replaced with hard-coded lorem ipsum. Confirm that any differences in the color of the placeholder for bolt images while they load is minor/unnoticeable.