Fix: typeahead search button misalignment #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
mikemai2awesome
changed the title
colbytcook
requested a deployment
to
bugfix/typeahead-button-position--be076e50--commit-preview
colbytcook
requested a deployment
to
bugfix/typeahead-button-position--216bffb--commit-preview
danielamorse
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a visual regression where the typeahead's search button is misaligned.
Details
How to test
Run the branch locally and check the typeadead docs with and without JS. When tabbing to the icon-only search button within the typeahead, it should not be misaligned.