DS-752 Remove ssr-server and all related code (Part 1) #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielamorse
changed the title
github-actions
bot
added
the
type: feature
remydenton
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Does the fact that I love seeing deleted code mean I'm getting old? I'll just tell myself it's the fact that the deleted code had incorrect comments and logic bugs. In any case, 😍 .
The code changes make sense to me, and it looks like the build is passing, approved.
| @@ -31,7 +31,6 @@ async function getDefaultConfig() { | |||
| proxyHostname: configSchema.properties.proxyHostname.default, | |||
| proxyHeader: configSchema.properties.proxyHeader.default, | |||
| ip, | |||
| enableSSR: configSchema.properties.enableSSR.default, | |||
There was a problem hiding this comment.
Fun fact, there was no default defined in the schema. I guess it happened to work because it defaulted to something false-y 🤷 .
| @@ -125,9 +125,6 @@ program | |||
| config.prod = | |||
| typeof program.prod === 'undefined' ? config.prod : program.prod; | |||
|
|
|||
| // automatically set enableSSR to true in prod mode and false in dev mode, unless manually set. | |||
| config.enableSSR = false; | |||
There was a problem hiding this comment.
The comment must be inaccurate? Looks to me like it's disabled in both prod and dev modes...
colbytcook
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-752
Summary
Remove ssr-server and all other experimental SSR code.
Details
SSR was an experiment to pass HTML to a back-end service and get back rendered web component HTML. It mostly worked but was never used and isn't needed going forward. We're removing it as part of repo clean up.
How to test