DS-756 Fix css animation selector #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 8, 2022 16:40
github-actions
bot
added
the
type: bugfix
danielamorse
approved these changes
Apr 8, 2022
mikemai2awesome
approved these changes
Apr 8, 2022
remydenton
approved these changes
Apr 8, 2022
andrewmriv
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-756
Summary
Attributes selectors were replaced with specific classes.
Details
[class*='a-bolt-']replaced with.a-bolt-base[class*='a-bolt-in']replaced with.a-bolt-in[class*='a-bolt-out']replaced with.a-bolt-outJS file was updated with the new class
Animation test pages were updated with the new classes in the Tests folder.
How to test
Pull the branch. Check if new classes are specific enough to avoid targeting other random classes. Go to test pages and confirm that animations work as previously.