Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-760 fix switch button label text #2477

Merged
merged 2 commits into from Apr 15, 2022

Conversation

mikemai2awesome
Copy link
Collaborator

Jira

https://pegadigitalit.atlassian.net/browse/DS-760

Summary

Fixes a bug where the switch button's label text is announced twice.

Details

  1. Aria attributes added to prevent the redundant announcments
  2. Doc page updated with better copy

How to test

  1. Run the branch locally
  2. Go to the Switch Button doc
  3. Use screen reader and tab to the switch button in the demo.
  4. Press either enter or space
  5. Listen to screen reader

@github-actions github-actions bot added the type: bugfix List this PR in the 'Bug Fixes' section of the release notes. label Apr 12, 2022
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemai2awesome verified fixed. I noticed this only happens in Safari, not in Chrome.

@danielamorse danielamorse merged commit b4b00e5 into master Apr 15, 2022
@danielamorse danielamorse deleted the bugfix/ds-760-switch-button-label-text branch April 15, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix List this PR in the 'Bug Fixes' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants