Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-540: scroll to top demo warning #2481

Merged
merged 2 commits into from
Apr 18, 2022
Merged

DS-540: scroll to top demo warning #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5771e7
DS-540: scroll to top demo warning
cjwhitedev Apr 18, 2022
1a3276a
DS-540: add warning to more pages
cjwhitedev Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ab/_patterns/40-components/floating-action-buttons/-05a-floating-action-buttons-demo.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% set layout_items %}
{% set banner %}
{% include '@bolt-components-banner/banner.twig' with {
content: 'This demo shows the usage of basic floating action buttons. In this particular case, a scroll to top button is utilized.',
content: 'This demo shows the usage of basic floating action buttons. In this particular case, a scroll to top button is utilized. Please note that the scroll to top button will not animate properly unless the demo is opened in a new page (outside the pattern-lab wrapper).',
align: 'start',
} only %}
{% endset %}
Expand Down
2 changes: 1 addition & 1 deletion ...ts/floating-action-buttons/-10a-floating-action-buttons-demo-show-on-scroll-selector.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% set layout_items %}
{% set banner %}
{% include '@bolt-components-banner/banner.twig' with {
content: 'This demo shows individual floating action buttons to show on scroll. Once the user scrolls past Article Title, the buttons appear.',
content: 'This demo shows individual floating action buttons to show on scroll. Once the user scrolls past Article Title, the buttons appear. Please note that the scroll to top button will not animate properly unless the demo is opened in a new page (outside the pattern-lab wrapper).',
align: 'start',
} only %}
{% endset %}
Expand Down
2 changes: 1 addition & 1 deletion ...0-components/floating-action-buttons/-15a-floating-action-buttons-demo-toggle-button.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% set layout_items %}
{% set banner %}
{% include '@bolt-components-banner/banner.twig' with {
content: 'This demo shows the usage of the toggle button. In this particular case, the toggle button is used to show more actions (a list of secondary action buttons).',
content: 'This demo shows the usage of the toggle button. In this particular case, the toggle button is used to show more actions (a list of secondary action buttons). Please note that the scroll to top button will not animate properly unless the demo is opened in a new page (outside the pattern-lab wrapper).',
align: 'start',
} only %}
{% endset %}
Expand Down
2 changes: 1 addition & 1 deletion ...mponents/floating-action-buttons/-999a-floating-action-buttons-demo-use-case-offsets.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% set layout_items %}
{% set banner %}
{% include '@bolt-components-banner/banner.twig' with {
content: 'This demo shows using offsets to further adjust the placement of FAB.',
content: 'This demo shows using offsets to further adjust the placement of FAB. Please note that the scroll to top button will not animate properly unless the demo is opened in a new page (outside the pattern-lab wrapper).',
align: 'start',
} only %}
{% endset %}
Expand Down
2 changes: 1 addition & 1 deletion ...ttern-lab/_patterns/40-components/floating-action-buttons/05-floating-action-buttons.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% set notes %}
<bolt-ol>
<bolt-li>One or many action buttons can be used.</bolt-li>
<bolt-li>The most common use case is a &ldquo;back to top&rdquo; button.</bolt-li>
<bolt-li>The most common use case is a &ldquo;back to top&rdquo; button. Please note that the scroll to top button will not animate properly unless the demo is opened in a new page (outside the pattern-lab wrapper).</bolt-li>
<bolt-li>When using a <a href="link['viewall-elements-button']">Button element</a> as FAB, it is recommended to use an icon-only button with tooltip. Set <code>placement</code> of tooltip to <code>left</code> to avoid clashing with other buttons.</bolt-li>
</bolt-ol>
{% endset %}
Expand Down