Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightcove Audio Player #2482

Merged
merged 4 commits into from May 2, 2022
Merged

Brightcove Audio Player #2482

merged 4 commits into from May 2, 2022

Conversation

colbytcook
Copy link
Contributor

Jira

https://pegadigitalit.atlassian.net/browse/WWW-1304

Summary

Updated the Bolt Brightcove init functionality to include the audio player

Details

  • Created a testing page
  • Modified the Brightcove initialization script to handle the new audio player

How to test

  • Pull Down Branch
  • Navigate to '/pattern-lab/?p=tests-audio-player'

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Apr 21, 2022
@colbytcook colbytcook temporarily deployed to feature/www-1304-audio-player--branch-preview April 21, 2022 16:48 Inactive
@colbytcook colbytcook had a problem deploying to feature/www-1304-audio-player--branch-preview April 27, 2022 19:13 Failure
@colbytcook colbytcook changed the title [DO NOT MERGE] Audio Player Test Brightcove Audio Player Apr 29, 2022
@colbytcook colbytcook temporarily deployed to feature/www-1304-audio-player--branch-preview April 29, 2022 19:04 Inactive
Copy link
Collaborator

@remydenton remydenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I left a few inline changes/questions.

@remydenton remydenton merged commit 4a62611 into master May 2, 2022
@remydenton remydenton deleted the feature/www-1304-audio-player branch May 2, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants