DS-771 Carousel breaks inside layout grid #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
danielamorse
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
@MarcinMr I think you found the root issue, nicely done! It seems there were rules applying only to "no-overflow" that should've applied to both "overflow" and "no-overflow".
I used the test page to reproduce the old bug and to verify the fix 🎉
danielamorse
deleted the
bugfix/DS-771-Carousel-breaks-inside-layout-grid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-771
Summary
The carousel placed inside
.l-bolt-siteshould stay centered without left or right misaligning.Details
The carousel should have an active slide centered horizontally in the viewport in all carousel variations such as these below:
overflowset totrueoverflowset totrueoverflowprop)How to test
Pull the beach. Go to the
/pattern-lab/?p=tests-carousel-in-layoutand see the carousel variations. Check if the carousel's active slide is always centered.