Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole Card Clickabilty Test Page #2503

Merged
merged 3 commits into from Jul 7, 2022
Merged

Conversation

colbytcook
Copy link
Contributor

Jira

https://pegadigitalit.atlassian.net/browse/WWW-1480

Summary

Created a test page to test out different methods of whole card clickability

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Jul 6, 2022
@colbytcook colbytcook temporarily deployed to feature/www-1480-card-modal-test--branch-preview July 6, 2022 19:27 Inactive
@remydenton
Copy link
Collaborator

Overall looks good, thanks for adding this.

I noticed the "Open a modal" button in the Existing Card With Button example doesn't work. Is that a known issue? If so, might be helpful to add a small note that it isn't expected to work currently.

Screen.Recording.2022-07-07.at.12.28.01.PM.mov

@colbytcook
Copy link
Contributor Author

@remydenton yea sorry, I will update this to be more apparent to why it breaks. I added a note in the description but I will make it more pronounced, one sec (I will also fix the silly typo!)

@colbytcook colbytcook temporarily deployed to feature/www-1480-card-modal-test--branch-preview July 7, 2022 17:27 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Teaser solution is definitely the way to go. Wrapping the card in a button works but technically only "phrasing content" is permitted inside a button. When we put a whole card inside the button it has no accessible name. I added aria-label to the Trigger example as a slight improvement, but still strongly recommend going with Teaser for accessibility reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants