Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-736: Element Icon JS Docs #2514

Merged
merged 3 commits into from Jul 15, 2022
Merged

Conversation

cjwhitedev
Copy link
Collaborator

Jira

DS-736

Summary

Add a doc site entry to show how to use the element icon in JavaScript.

Details

Add a doc site entry to show how to use the element icon in JavaScript.

How to test

Review the doc site entry.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Jul 14, 2022
@colbytcook colbytcook temporarily deployed to feature/ds-736-icon-js-docs--branch-preview July 14, 2022 14:35 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwhitedev, thanks for setting this up. I added a bit to it. Take a look, just so you're familiar with what I added.

Also, please check that your tab indentation is set to two-spaces. Looks like it might be set to four?

@danielamorse danielamorse merged commit 4123ec0 into master Jul 15, 2022
@danielamorse danielamorse deleted the feature/ds-736-icon-js-docs branch July 15, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants