DS-799 Object Inline List deprecation #2515
Conversation
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/DS-799-inline-list-deprecation--branch-preview
| @@ -414,7 +414,7 @@ $bolt-input-transition: var(--bolt-transition); | |||
| top: 1px; | |||
| right: 1px; | |||
| padding-top: calc( | |||
| var(--bolt-spacing-y-medium) / 2 - 0.25rem | |||
| var(--bolt-spacing-y-medium) / 2.5 - 0.25rem | |||
There was a problem hiding this comment.
@MarcinMr is this change intended? I don't see any mention of it in the description so I wanted to double check.
There was a problem hiding this comment.
@colbytcook After replacing o-bolt-list with the list component I saw a small vertical misalignment of icons inside form input, this is why I adjusted it a little bit.
There was a problem hiding this comment.
@MarcinMr minor suggestion: since we're already using one "magic number" here, .25rem, I would leave the divisor as 2 and tweak the .25rem value as needed.
Also, see Mike's comment on the next line and please update the comment with the new value. You can test the Japanese alignment by changing the [lang] tag on the <html> element to lang="ja".
Be sure to pull the latest before making updates. I resolved a conflict with the .incache file.
There was a problem hiding this comment.
@danielamorse thanks for the suggestion, I updated the numbers and comment
There was a problem hiding this comment.
Vertical alignment before changes
Vertical alignment after changes
colbytcook
temporarily deployed
to
feature/DS-799-inline-list-deprecation--branch-preview
| @@ -414,7 +414,7 @@ $bolt-input-transition: var(--bolt-transition); | |||
| top: 1px; | |||
| right: 1px; | |||
| padding-top: calc( | |||
| var(--bolt-spacing-y-medium) / 2 - 0.25rem | |||
| var(--bolt-spacing-y-medium) / 2.5 - 0.25rem | |||
There was a problem hiding this comment.
@MarcinMr minor suggestion: since we're already using one "magic number" here, .25rem, I would leave the divisor as 2 and tweak the .25rem value as needed.
Also, see Mike's comment on the next line and please update the comment with the new value. You can test the Japanese alignment by changing the [lang] tag on the <html> element to lang="ja".
Be sure to pull the latest before making updates. I resolved a conflict with the .incache file.
# Conflicts: # docs-site/.incache
colbytcook
temporarily deployed
to
feature/DS-799-inline-list-deprecation--branch-preview
Jira
https://pegadigitalit.atlassian.net/browse/DS-799
Summary
Usage of
o-bolt-inline-listwere replaced with bolt-componentListas was recommended in the research ticketDetails
Places where
inline-list objectwas updated with Bolt-componentList:How to test
Check if there are no regressions due to the replacement
inline-list objectwith theListcomponent.Release notes
Object inline-list is deprecated. Please use the Bolt component
List.