DS-811 Wrapper Element #2522
Merged
DS-811 Wrapper Element #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/DS-811-Wrapper-Element--branch-preview
added 2 commits
August 2, 2022 12:41
colbytcook
requested a deployment
to
feature/DS-811-Wrapper-Element--3dbc663--commit-preview
colbytcook
temporarily deployed
to
feature/DS-811-Wrapper-Element--branch-preview
colbytcook
temporarily deployed
to
feature/DS-811-Wrapper-Element--branch-preview
colbytcook
requested a deployment
to
feature/DS-811-Wrapper-Element--8bd57ea--commit-preview
colbytcook
requested a deployment
to
feature/DS-811-Wrapper-Element--branch-preview
cjwhitedev
approved these changes
Aug 5, 2022
danielamorse
requested changes
Aug 9, 2022
There was a problem hiding this comment.
@MarcinMr I left some copy suggestions. If this sounds good, please apply the changes and commit (you can do this right in Github FYI).
Otherwise, this looks great! I created a small test page locally to verify it works just like o-bolt-wrapper.
docs-site/src/pages/pattern-lab/_patterns/20-elements/wrapper/05-wrapper.twig
Outdated
Show resolved
Hide resolved
...rc/pages/pattern-lab/_patterns/20-elements/wrapper/10-wrapper-use-case-custom-max-width.twig
Outdated
Show resolved
Hide resolved
colbytcook
temporarily deployed
to
feature/DS-811-Wrapper-Element--branch-preview
Co-authored-by: Dan Morse <danielamorse@gmail.com>
Co-authored-by: Dan Morse <danielamorse@gmail.com>
Co-authored-by: Dan Morse <danielamorse@gmail.com>
colbytcook
requested a deployment
to
feature/DS-811-Wrapper-Element--4f65453--commit-preview
colbytcook
requested a deployment
to
feature/DS-811-Wrapper-Element--3749ae3--commit-preview
|
@danielamorse approved your suggestions |
danielamorse
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-811
Summary
A new wrapper element is created.
Details
A new wrapper is a basic element that contains a basic schema with
contentandattributes.How to test
Pull the branch. Check the wrapper docs and confirm it's a good equivalent of the old wrapper object.
Release notes
The
o-bolt-wrapperobject is deprecated. Please use thee-bolt-wrapperelement instead.