Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-733: make tabs show-more button invisble by default #2529

Merged
merged 2 commits into from Aug 22, 2022

Conversation

cjwhitedev
Copy link
Collaborator

Jira

https://pegadigitalit.atlassian.net/browse/DS-733

Summary

Make the tabs show-more button invisble on page-load to prevent an unstyled flash

Details

Make the tabs show-more button invisble on page-load to prevent an unstyled flash

How to test

refresh a page with tabs on it, confirm that you are no longer seeing the more button flash before hiding again.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Aug 18, 2022
Copy link
Collaborator

@MarcinMr MarcinMr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any flash of the more button when refreshing. I tested also with the dev tools options network fast 3G and slow 3G, seems like it works nice now.

Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwhitedev would you please try out my suggestion and let me know if it works?

packages/components/bolt-tabs/src/tabs.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@MarcinMr MarcinMr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like still works as expected

@danielamorse danielamorse self-requested a review August 22, 2022 21:12
@danielamorse danielamorse merged commit 2220752 into master Aug 22, 2022
@danielamorse danielamorse deleted the feature/DS-733-tabs-more-button-flash branch August 22, 2022 21:19
danielamorse added a commit that referenced this pull request Aug 29, 2022
…re-button-flash

DS-733: make tabs show-more button invisble by default
@danielamorse danielamorse mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants