Patternlab Browser Support Link #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbytcook
temporarily deployed
to
feature/DS-827-Patternlab-Browser-Suppor-Link--branch-preview
github-actions
bot
added
the
type: feature
…o feature/DS-827-Patternlab-Browser-Suppor-Link
colbytcook
requested a deployment
to
feature/DS-827-Patternlab-Browser-Suppor-Link--69fc6bec--commit-preview
colbytcook
had a problem deploying
to
feature/DS-827-Patternlab-Browser-Suppor-Link--69fc6bec--commit-preview
colbytcook
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-827
Summary
A link to the browser list page with our set browser support was added to the left PL navigation sidebar.
Details
copied
bar-chart-circleicon from theelements / bolt-icon / src / icons / svgstowebsite-ui / uikit-workshop / src / iconsand named itbrowser-support☝️ Didn't find any suitable icon in
website-ui / uikit-workshop / ... /. This is why I copied that icon and add touikit-workshopfolder. This icon suits me because the bar chart somehow resembles the percentage support.added a new tab named
Browser Supportto the PL navigation sidebarHow to test
Check if the new link links to the proper page and if the formula is correct.
Release notes
The new tab link is added to the left sidebar navigation.