DS-839: Fix broken schema to fix full_bleed prop #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
colbytcook
had a problem deploying
to
bugfix/DS-839-fix-full-bleed--5466daf--commit-preview
MarcinMr
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Seems like full-bleed works properly. The photo is aligned left on desktops. On tablets and mobiles is centered. It looks well in relation to these mockups: https://pegadigitalit.atlassian.net/browse/DS-679
cjwhitedev
approved these changes
Sep 6, 2022
danielamorse
added a commit
that referenced
this pull request
Sep 7, 2022
…-bleed DS-839: Fix broken schema to fix full_bleed prop
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-839
Summary
Fix broken schema to fix
full_bleedprop.Details
In
5.7.1we added multiple schemas to Profile but did not update the originalprofile.twigfile to reference the schema. It now points to the schema properly and thefull_bleedprop works again.How to test