DS-835: Table Sticky Top Bugfix #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/DS-835-table-sticky-bug--branch-preview
colbytcook
temporarily deployed
to
feature/DS-835-table-sticky-bug--branch-preview
danielamorse
requested changes
Oct 18, 2022
colbytcook
temporarily deployed
to
feature/DS-835-table-sticky-bug--branch-preview
|
@danielamorse @MarcinMr I added the |
colbytcook
had a problem deploying
to
feature/DS-835-table-sticky-bug--d1f48a9--commit-preview
MarcinMr
approved these changes
Oct 19, 2022
danielamorse
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where the sticky top header would go behind the rows.
Details
Removed a unneeded CSS on the
trthat was causing this issue.How to test
Pull down the branch
Navigate to the
/pattern-lab/?p=tests-table-support-centerpageScroll down on the table and observe that the top header is sticking