Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS 889: Drupal Admin UI Paternlab Section #2579

Merged
merged 37 commits into from Dec 2, 2022

Conversation

MarcinMr
Copy link
Collaborator

@MarcinMr MarcinMr commented Nov 29, 2022

Jira

https://pegadigitalit.atlassian.net/browse/DS-889

Summary

There's a new section Drupal Admin UI in the pattern lab navigation which contains the UX builds of the Drupal Admin panels for the new Layout Builder project.

Details

1. In the Bolt, we have a new section with UX builds:

  • text paragraph
  • advanced text paragraph
  • icon paragraph
  • image paragraph
  • button paragraph
  • blockquote paragraph
  • list paragraph
  • action blocks paragraph
  • tabs and accordion paragraph

These above were recreated from the private Codepen.

2. The animation tab was updated

  • the animation type dropdown was removed
  • the animation style was updated to have only the fade and bounce for now

👉 it's possible that this will be updated again in the future

How to test

Pull the branch. Look at the Drupal admin UI section. Go thru all component examples and confirm that there are the same as Codepen examples.

Release notes

We have a new Drupal admin UI section in the pattern lab navigation.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Nov 29, 2022
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview November 29, 2022 13:29 Inactive
@colbytcook colbytcook had a problem deploying to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 09:04 Failure
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 10:18 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 11:17 Inactive
@colbytcook colbytcook had a problem deploying to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 12:43 Failure
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 13:16 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 13:23 Inactive
@colbytcook colbytcook temporarily deployed to feature/DS-889-Drupal-Admin-UI-Paternlab-Section--branch-preview December 1, 2022 15:46 Inactive
@MarcinMr
Copy link
Collaborator Author

MarcinMr commented Dec 1, 2022

@remydenton I made the changes it's ready to review again.

@colbytcook as we talked on Slack, I have some cache problems with hiding/unhiding the tabs in the Bolt left navigation.

In incognito mode and on my private windows seems to work

incognito.hiding.mov

But in the normal mode, it behaves not properly, even when I cleared the browser cache

noincognmito.hiding.mov

…o feature/DS-889-Drupal-Admin-UI-Paternlab-Section
Copy link
Collaborator

@remydenton remydenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good, thank you @MarcinMr.

For what it's worth, I had the same behavior in your screencast (wrong tabs display) when not in incognito mode. After I cleared local storage in developer tools, it worked as expected.

@remydenton remydenton merged commit 3900930 into master Dec 2, 2022
@remydenton remydenton deleted the feature/DS-889-Drupal-Admin-UI-Paternlab-Section branch December 2, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants