DS-868: Add description_clamp prop to Listing Teaser #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
danielamorse
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Looks good 👍 Approving with one comment...
At first, I thought we should call it "description_truncation" because most people don't know the term "clamp". On second thought, I like "clamp" because it's more accurate. It clamps to a number of lines - it doesn't truncate a number of words. It's probably good to familiarize users with this advanced feature by name.
So, I'm good with it as is, open to alternatives if you can think of anything better.
colbytcook
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-868
Summary
Add a new prop for Listing Teaser to toggle the line clamp on the description.
Details
Add a new prop for Listing Teaser to toggle the line clamp on the description.
How to test
Check out the new demo page.