DS-893: Long strings in notifications causes some minor layout issues #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
colbytcook
approved these changes
Dec 2, 2022
colbytcook
deleted the
bugfix/DS-893-SN-Long-strings-in-notifications-causes-some-minor-layout-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-893
Summary
The notification item doesn't overflow the container.
Details
When we have really long strings or URLs in the notification item, they shouldn't overflow the container but break the longest string.
How to test
Go to the tests page
/pattern-lab/?p=tests-notifications-long-stringsand confirm that long strings don't overflow the container.Release notes
The long strings in the notifications item don't overflow the container.