Change the display order of PAM messages #824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some suggestion to improve (in my opinion) the interaction between the user and the PAM module.
There are 3 test users on my computer, one just logs in with a password, the second one with the fingerprint scanner (
pam_fprintd.so
) and the third one with the help of howdy.Howdy works great, but I noticed a somewhat awkward behavior:
This request represents my attempt to improve it.
Since the comparison takes place in a separate script, I decided to connect to its stdout and, upon receiving theHAS_MODEL
string, prompt the user. Not sure if this is the best way, but it seems simple and painless enough.P.S. I just brought the behavior closer to that of the
pam_fprintd.so
module, and it seems to me quite convenient - if the user has not configured a fingerprint, we silently skip it, if we have configured it, we write an invitation, if authentication is unsuccessful, we write an error message and exit.