Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make callbacks async since we use async socketio client #8

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Make callbacks async since we use async socketio client #8

merged 2 commits into from
Oct 11, 2021

Conversation

bombsimon
Copy link
Owner

It makes more sense to use async callbacks and await them from the async socketio client so let's use async callbacks.

@bombsimon bombsimon merged commit c4467e3 into master Oct 11, 2021
@bombsimon bombsimon deleted the async-callbacks branch October 31, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bombsimon