Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic for empty BlockStmt #21

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Avoid panic for empty BlockStmt #21

merged 1 commit into from
Oct 2, 2019

Conversation

bombsimon
Copy link
Owner

Some blocks might be empty, example
https://github.com/golang/sys/blob/master/unix/gccgo.go#L16
To avoid this from panicking we just ignore those nodes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 61

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wsl.go 2 4 50.0%
Totals Coverage Status
Change from base Build 59: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 2, 2019

Pull Request Test Coverage Report for Build 63

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.06%

Totals Coverage Status
Change from base Build 59: 0.06%
Covered Lines: 854
Relevant Lines: 1004

💛 - Coveralls

Some blocks might be empty, example
https://github.com/golang/sys/blob/master/unix/gccgo.go#L16
To avoid this from panicking we just ignore those nodes.
@bombsimon bombsimon merged commit ff9f623 into master Oct 2, 2019
@bombsimon bombsimon deleted the empty-block branch October 7, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants