Merge 0cf0dd9 into 25bd701

boneskull · Aug 17, 2017 · c846cdc · c846cdc
2 parents 25bd701 + 0cf0dd9
commit c846cdc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -34,7 +34,7 @@ exports.findExternalInterface = function findExternalInterface (options) {
   var name = options.name;
 
   if (name) {
-    return findInAddresses(networkInterfaces[name]) ? name : null;
+    return (networkInterfaces[name]) ? (findInAddresses(networkInterfaces[name]) ? name : null) : null;
   }
 
   return Object.keys(networkInterfaces)

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -82,6 +82,19 @@ describe('findExternalInterface()', function () {
         expect(findExternalInterface({name: 'en14'})).to.be.null;
       });
     });
+
+    describe('and there is no matching interface', function () {
+      beforeEach(function () {
+        var interfaces = Object.assign({}, allInterfaces);
+        interfaces.en14 = interfaces.en13;
+        sandbox.stub(os, 'networkInterfaces')
+          .returns(interfaces);
+      });
+
+      it('should return null', function () {
+        expect(findExternalInterface({name: 'en15'})).to.be.null;
+      });
+    });
   });
 
   describe('when "name" option is an empty string', function () {