fix(headers) support multivaluated header values

* values are separated with a `;` Closes #30
bonitasoft · Sep 3, 2018 · c6a5375 · c6a5375
1 parent 19a5738
commit c6a5375
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 10 deletions.
diff --git a/infrastructure/release.groovy b/infrastructure/release.groovy
@@ -9,7 +9,7 @@ timestamps {
                             credentialsId: 'github',
                             passwordVariable: 'GIT_PASSWORD',
                             usernameVariable: 'GIT_USERNAME')]) {
-                                sh './mvnw release:prepare release:perform -B -DaltDeploymentRepository=${env.ALT_DEPLOYMENT_REPOSITORY_SNAPSHOTS}'
+                                sh "./mvnw -B release:prepare release:perform -Darguments=-DaltDeploymentRepository=${env.ALT_DEPLOYMENT_REPOSITORY_TAG}"
                        }
                 }
             }

diff --git a/src/main/java/org/bonitasoft/connectors/rest/RESTConnector.java b/src/main/java/org/bonitasoft/connectors/rest/RESTConnector.java
@@ -434,7 +434,14 @@ private Map<String, String> asMap(Header[] headers) {
         final Map<String, String> result = new HashMap<>();
         if (headers != null) {
             for (final Header header : headers) {
-                result.put(header.getName(), header.getValue());
+                String name = header.getName();
+                if (!result.containsKey(name)) {
+                    result.put(name, header.getValue());
+                } else {
+                    String currentValue = result.get(name);
+                    if (header.getValue() != null && !header.getValue().isEmpty())
+                    result.put(name, currentValue + ";" + header.getValue());
+                }
             }
         }
         return result;

diff --git a/src/main/resources/rest-delete.impl b/src/main/resources/rest-delete.impl
@@ -3,11 +3,11 @@
   <implementationId>rest-delete-impl</implementationId>
   <implementationVersion>$implementation.version$</implementationVersion>
   <definitionId>rest-delete</definitionId>
-  <definitionVersion>1.0.0</definitionVersion>
+  <definitionVersion>1.1.0</definitionVersion>
   <implementationClassname>org.bonitasoft.connectors.rest.DeleteConnectorImpl</implementationClassname>
   <hasSources>false</hasSources>
   <description>The implementation of the REST Delete Connector.</description>
 
 $Dependencies$
 
-</implementation:connectorImplementation>
+</implementation:connectorImplementation>
diff --git a/src/main/resources/rest-get.impl b/src/main/resources/rest-get.impl
@@ -3,11 +3,11 @@
   <implementationId>rest-get-impl</implementationId>
   <implementationVersion>$implementation.version$</implementationVersion>
   <definitionId>rest-get</definitionId>
-  <definitionVersion>1.0.0</definitionVersion>
+  <definitionVersion>1.1.0</definitionVersion>
   <implementationClassname>org.bonitasoft.connectors.rest.GetConnectorImpl</implementationClassname>
   <hasSources>false</hasSources>
   <description>The implementation of the REST GET Connector.</description>
 
 $Dependencies$
 
-</implementation:connectorImplementation>
+</implementation:connectorImplementation>
diff --git a/src/main/resources/rest-post.impl b/src/main/resources/rest-post.impl
@@ -3,11 +3,11 @@
   <implementationId>rest-post-impl</implementationId>
   <implementationVersion>$implementation.version$</implementationVersion>
   <definitionId>rest-post</definitionId>
-  <definitionVersion>1.0.0</definitionVersion>
+  <definitionVersion>1.1.0</definitionVersion>
   <implementationClassname>org.bonitasoft.connectors.rest.PostConnectorImpl</implementationClassname>
   <hasSources>false</hasSources>
   <description>The implementation of the REST POST Connector.</description>
 
 $Dependencies$
 
-</implementation:connectorImplementation>
+</implementation:connectorImplementation>
diff --git a/src/main/resources/rest-put.impl b/src/main/resources/rest-put.impl
@@ -3,11 +3,11 @@
   <implementationId>rest-put-impl</implementationId>
   <implementationVersion>$implementation.version$</implementationVersion>
   <definitionId>rest-put</definitionId>
-  <definitionVersion>1.0.0</definitionVersion>
+  <definitionVersion>1.1.0</definitionVersion>
   <implementationClassname>org.bonitasoft.connectors.rest.PutConnectorImpl</implementationClassname>
   <hasSources>false</hasSources>
   <description>The implementation of the REST PUT Connector.</description>
 
 $Dependencies$
 
-</implementation:connectorImplementation>
+</implementation:connectorImplementation>