Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and improve sql package #1

Open
7 of 8 tasks
alespour opened this issue Jun 24, 2020 · 0 comments
Open
7 of 8 tasks

fix and improve sql package #1

alespour opened this issue Jun 24, 2020 · 0 comments
Assignees

Comments

@alespour
Copy link
Collaborator

alespour commented Jun 24, 2020

Branch: https://github.com/bonitoo-io/flux/tree/fix/sql-misc

Bugs:

  • Snowflake: translationFunc - missing outgoing TUint mapping
  • Snowflake: InitColumnTypes - only when scale == 0 then integer can be assumed
  • MySQL: translationFunc: TUint should map to BIGINT UNSIGNED
  • all: translationFunc: unsupported type error whould be reported with codes.Invalid instead of codes.Internal

Refactor:

  • mysql, postgres, sqlite - map should be outside of translationFunc and not use String() just like in recently added db supports
  • to.go: CreateInsertComponents() - getTranslationFunc() called in loop, label map not used anywhere

Enhancements:

  • Azure: use new public API to get tokens, at least for MSI token
    • go.mod NOTE There already is a pending PR #3172 for Azure dep update
      • autorest: v0.11.4
      • adal: v0.9.2
@alespour alespour self-assigned this Jun 24, 2020
alespour pushed a commit that referenced this issue Nov 16, 2020
)

* feat(stdlib/contrib): Add stdlib/contrib package events

* feat(stdlib/contrib): Add stdlib/contrib package events (#1)

* fix(stdlib/contrib): copy editing

* feat(stdlib/contrib): additional test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant