New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RT #93705: #3

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@xsawyerx

xsawyerx commented Mar 27, 2016

Test::Database uses File::Path::mkpath() which returns the
directory if it created it. Saving it in $self and then checking
it to decide whether to delete the directory or not.

I'm not sure this is good enough, since the directory could have
already existed and then we don't delete anything.

If DBD::CSV provided any information on what files were created,
or if we had any introspection to the "CREATE" statements, then
we might take care of it with finer detail and cover both cases.

Fix RT #93705:
Test::Database uses File::Path::mkpath() which returns the
directory if it created it. Saving it in $self and then checking
it to decide whether to delete the directory or not.

I'm not sure this is good enough, since the directory could have
already existed and then we don't delete anything.

If DBD::CSV provided any information on what files were created,
or if we had any introspection to the "CREATE" statements, then
we might take care of it with finer detail and cover both cases.
@xsawyerx

This comment has been minimized.

Show comment
Hide comment
@xsawyerx

xsawyerx Mar 27, 2016

This is just a sample fix. It might not be good enough.

xsawyerx commented Mar 27, 2016

This is just a sample fix. It might not be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment