Fix RT #93705: #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test::Database uses File::Path::mkpath() which returns the directory if it created it. Saving it in $self and then checking it to decide whether to delete the directory or not. I'm not sure this is good enough, since the directory could have already existed and then we don't delete anything. If DBD::CSV provided any information on what files were created, or if we had any introspection to the "CREATE" statements, then we might take care of it with finer detail and cover both cases.
|
This is just a sample fix. It might not be good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test::Database uses File::Path::mkpath() which returns the
directory if it created it. Saving it in $self and then checking
it to decide whether to delete the directory or not.
I'm not sure this is good enough, since the directory could have
already existed and then we don't delete anything.
If DBD::CSV provided any information on what files were created,
or if we had any introspection to the "CREATE" statements, then
we might take care of it with finer detail and cover both cases.