-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB-426: fix text overflow on buttons on small screens #378
Conversation
@MonkeyDo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can find a more generic approach that would benefit other buttons where this problem could happen.
This reverts commit 45e3b9c.
…into uiImprovement
@MonkeyDo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, after this small change it's ready to merge!
Thanks!
src/client/stylesheets/style.less
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra blank lines here
@MonkeyDo |
…e into uiImprovement
@MonkeyDo |
Thanks @endurance21 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@endurance21 Can I do this? |
@prabalsingh24 ya sure. |
A previous fix in PR #378 was causing an issue. We only want this text wrap behavior on buttons with a lot of text, so add a class selector.
Problem
https://tickets.metabrainz.org/browse/BB-426?filter=-2
Solution
no more text overflow on device having width below "451px"'
Areas of Impact
src/client/entity-editor/edition-section/edition-section.js
src/client/stylesheets/style.less