feat: Support disabling and auto-hiding notifications. resolved #214

bookfere · Apr 13, 2024 · 33ed918 · 33ed918
1 parent a69939c
commit 33ed918
Show file tree

Hide file tree

Showing 14 changed files with 184 additions and 147 deletions.
diff --git a/batch.py b/batch.py
@@ -78,10 +78,10 @@ def layout_translate(self):
                     .set_encoding(encoding))
             else:
                 input_encoding = QLabel(_('Default'))
-            table.setCellWidget(row, 2, input_encoding)
+            table.setCellWidget(row, 1, input_encoding)
 
             input_fmt = InputFormat(ebook.files.keys())
-            table.setCellWidget(row, 1, input_fmt)
+            table.setCellWidget(row, 2, input_fmt)
 
             output_format = OutputFormat()
             table.setCellWidget(row, 3, output_format)

diff --git a/lib/config.py b/lib/config.py
@@ -16,6 +16,7 @@
     'cache_enabled': True,
     'cache_path': None,
     'log_translation': True,
+    'show_notification': True,
     'translation_position': None,
     'column_gap': {
         '_type': 'percentage',

diff --git a/lib/conversion.py b/lib/conversion.py
@@ -332,13 +332,13 @@ def callback(payload):
                 kwargs = {'args': ['ebook-viewer', output_path]}
                 payload('ebook-viewer', kwargs=kwargs)
 
-        self.gui.proceed_question(
-            callback,
-            self.gui.job_manager.launch_gui_app,
-            job.log_path,
-            _('Ebook Translation Log'),
-            _('Translation Completed'),
-            _('The translation of "{}" was completed. '
-              'Do you want to open the book?').format(ebook_title),
-            log_is_file=True,
-            icon=self.icon)
+        if self.config.get('show_notification', True):
+            self.gui.proceed_question(
+                callback,
+                self.gui.job_manager.launch_gui_app,
+                job.log_path,
+                _('Ebook Translation Log'),
+                _('Translation Completed'),
+                _('The translation of "{}" was completed. '
+                'Do you want to open the book?').format(ebook_title),
+                log_is_file=True, icon=self.icon, auto_hide_after=5)
diff --git a/setting.py b/setting.py
@@ -295,12 +295,23 @@ def change_input_format(format):
         log_layout.addStretch(1)
         misc_layout.addWidget(log_group, 1)
 
+        # Notification
+        notice_group = QGroupBox(_('Notification'))
+        notice_layout = QHBoxLayout(notice_group)
+        notice = QCheckBox(_('Enable'))
+        notice_layout.addWidget(notice)
+        misc_layout.addWidget(notice_group, 1)
+
         layout.addWidget(misc_widget)
 
-        log_translation.setChecked(self.config.get('log_translation'))
+        log_translation.setChecked(self.config.get('log_translation', True))
         log_translation.toggled.connect(
             lambda checked: self.config.update(log_translation=checked))
 
+        notice.setChecked(self.config.get('show_notification', True))
+        notice.toggled.connect(
+            lambda checked: self.config.update(show_notification=checked))
+
         # Search path
         path_group = QGroupBox(_('Search Paths'))
         path_layout = QVBoxLayout(path_group)

diff --git a/tests/test_config.py b/tests/test_config.py
@@ -21,6 +21,7 @@ def test_default(self):
             'cache_enabled': True,
             'cache_path': None,
             'log_translation': True,
+            'show_notification': True,
             'translation_position': None,
             'column_gap': {
                 '_type': 'percentage',

diff --git a/translations/es.po b/translations/es.po
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Ebook Translator Calibre Plugin\n"
 "Report-Msgid-Bugs-To: bookfere@gmail.com\n"
-"POT-Creation-Date: 2024-04-12 23:49+0800\n"
+"POT-Creation-Date: 2024-04-13 10:33+0800\n"
 "PO-Revision-Date: 2023-04-17 14:17+0800\n"
 "Last-Translator: Automatically generated\n"
 "Language-Team: none\n"
@@ -566,6 +566,9 @@ msgstr ""
 msgid "Show translation"
 msgstr "Mostrar traducción"
 
+msgid "Notification"
+msgstr ""
+
 msgid "Search Paths"
 msgstr ""
 

diff --git a/translations/fr.po b/translations/fr.po
@@ -4,7 +4,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Ebook Translator Calibre Plugin\n"
 "Report-Msgid-Bugs-To: bookfere@gmail.com\n"
-"POT-Creation-Date: 2024-04-12 23:49+0800\n"
+"POT-Creation-Date: 2024-04-13 10:33+0800\n"
 "PO-Revision-Date: 2023-10-01 15:35-0400\n"
 "Last-Translator: <a href=\"https://www.mobileread.com/forums/member.php?"
 "u=90932\">PoP</a>\n"
@@ -575,6 +575,9 @@ msgstr "Registre de travail"
 msgid "Show translation"
 msgstr "Montrer la traduction"
 
+msgid "Notification"
+msgstr ""
+
 msgid "Search Paths"
 msgstr ""