Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Application Cluster Names In shipperctl admin clusters apply #64

merged 5 commits into from Apr 2, 2019


None yet
3 participants
Copy link

commented Jan 16, 2019

This pull request does the following:

  • Moves the validation of the application cluster to the very beginning so that we don't leave the clusters in a half-state
  • Validates the application cluster name to make sure that it's a valid object name. The reason this is not done for the management cluster is that the management cluster is not turned into a Cluster object.

Fixes #61.

@kanatohodets kanatohodets force-pushed the shipperctl-apply-validation branch from 8e82616 to 0192bcf Feb 9, 2019

parhamdoustdar added some commits Jan 15, 2019

- Moved validation of `shipperctl admin clusters apply` higher up in the
process, to prevent the command leaving the configuration in a
half-state because of a validation error
- Added an extra line of validation to validate that cluster names are
DNS-1123 subdomain compliant.

@parhamdoustdar parhamdoustdar force-pushed the shipperctl-apply-validation branch from 0192bcf to 9a74472 Feb 12, 2019

parhamdoustdar added some commits Feb 12, 2019

- Made the title for the new section in the doc clearer, and also
  changed the link in the CLI output
- Used `%q` in the error output to have Go automatically quote the
  error message, instead of doing it by hand
- Changed `ValidateConfiguration` to `ValidateApplicationClusters`
  which is more "true" ;-)

@parhamdoustdar parhamdoustdar requested a review from icanhazbroccoli Mar 12, 2019

@icanhazbroccoli icanhazbroccoli merged commit ff70e7e into master Apr 2, 2019

2 checks passed

Travis CI - Branch Build Passed
Travis CI - Pull Request Build Passed

@parhamdoustdar parhamdoustdar deleted the shipperctl-apply-validation branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.