This repository has been archived by the owner on May 3, 2022. It is now read-only.
Validate Application Cluster Names In shipperctl admin clusters apply #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanatohodets
force-pushed
the
shipperctl-apply-validation
branch
from
8e82616
to
0192bcf
Compare
process, to prevent the command leaving the configuration in a half-state because of a validation error - Added an extra line of validation to validate that cluster names are DNS-1123 subdomain compliant.
to the relevant example.
parhamdoustdar
force-pushed
the
shipperctl-apply-validation
branch
from
0192bcf
to
9a74472
Compare
osdrv
reviewed
Feb 19, 2019
osdrv
reviewed
Feb 19, 2019
osdrv
reviewed
Feb 19, 2019
changed the link in the CLI output - Used `%q` in the error output to have Go automatically quote the error message, instead of doing it by hand - Changed `ValidateConfiguration` to `ValidateApplicationClusters` which is more "true" ;-)
juliogreff
approved these changes
Mar 19, 2019
osdrv
approved these changes
Apr 2, 2019
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does the following:
Fixes #61.