taskvent sends start-batch to sink; Java example sleeps the correct amount of time #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kers. Sockets and Context are closed properly.
hintjens
added a commit
that referenced
this pull request
Jul 29, 2011
taskvent sends start-batch to sink; Java example sleeps the correct amount of time
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits solve issue #86 and #87.
The taskvent.c now opens an additional socket and sends the start-batch to the sink to signal the start of the processing.
The Java example now sleeps the correct amount of time and also sends the start-batch to the sink. Additionally I've included close() and term() calls since the Java-binding provides these methods and I think it's good practice to properly close all opened resources.
HTH,
Michael