feat(constructor): detect knex on construction #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardograca
reviewed
Feb 7, 2018
src/bookshelf.js
Outdated
| @@ -24,6 +24,9 @@ import Errors from './errors'; | |||
| * @param {Knex} knex Knex instance. | |||
| */ | |||
| function Bookshelf(knex) { | |||
| if (!knex || !knex.__knex__) { | |||
There was a problem hiding this comment.
This started throwing a warning when running tests:
Knex:warning - knex.__knex__ is deprecated, you can get the module versionby running require('knex/package').version
Can you look into it?
There was a problem hiding this comment.
yep. sorry i missed that.
BREAKING CHANGE: although uncommon and unlikely, invalid construction was permissible in the past. now, we eagerly throw. this has a low but feasible chance of breaking some existing installs/usages.
cdaringe
force-pushed
the
feat/detect-knex-on-construction
branch
from
9e3ab74
to
4906279
Compare
|
|
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
a bad knex arg is allowed on construction
Motivation
fail fast
Proposed solution
disallow a bad knex arg on construction