Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(constructor): detect knex on construction #1756
+8
−0
Conversation
src/bookshelf.js
Outdated
| @@ -24,6 +24,9 @@ import Errors from './errors'; | ||
| * @param {Knex} knex Knex instance. | ||
| */ | ||
| function Bookshelf(knex) { | ||
| if (!knex || !knex.__knex__) { |
This comment has been minimized.
This comment has been minimized.
ricardograca
Feb 7, 2018
Member
This started throwing a warning when running tests:
Knex:warning - knex.__knex__ is deprecated, you can get the module versionby running require('knex/package').version
Can you look into it?
This comment has been minimized.
This comment has been minimized.
ricardograca
added
the
feature request
label
Feb 7, 2018
ricardograca
added this to To Do
in Version 0.13.0
via automation
Feb 7, 2018
ricardograca
moved this from To Do
to In Progress
in Version 0.13.0
Feb 7, 2018
This comment has been minimized.
This comment has been minimized.
|
|
ricardograca
merged commit 0c7b726
into
bookshelf:master
Feb 8, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Version 0.13.0
automation
moved this from In Progress
to Done
Feb 8, 2018
This comment has been minimized.
This comment has been minimized.
|
Many thanks! |
ricardograca
referenced this pull request
Mar 17, 2018
Merged
Use a different method to check for Knex on Bookshelf construction #1788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cdaringe commentedFeb 6, 2018
Introduction
a bad knex arg is allowed on construction
Motivation
fail fast
Proposed solution
disallow a bad knex arg on construction