Fix morphTo options.query #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use same query builder for all candidates
ricardograca
requested changes
Feb 27, 2020
Member
ricardograca
left a comment
ricardograca
left a comment
There was a problem hiding this comment.
Can you add a test case for this issue? That should help ensure it's not re-introduced at a later time.
Contributor
Author
|
@ricardograca Added a passing test (finally) that fails if I remove my fix. |
Contributor
Author
|
@ricardograca I changed the test setup to better fit the existing structure, please check to see if it makes sense. |
ricardograca
approved these changes
Mar 2, 2020
Member
ricardograca
left a comment
ricardograca
left a comment
There was a problem hiding this comment.
Thanks! It's better now.
Contributor
Author
|
@ricardograca Great! Thanks. When can we expect the next version to be published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use same query builder for all candidates
Introduction
fetchingevent gets same query builder for all morphTo candidates.Motivation
We're using on('fetching', ..) to add deleted_at check for relations, but this fails for morphTo relations, since opts.query is the same regardless of candidate.
Proposed solution
Remove query from options prior to sending it to sync, solves this issue.
Current PR Issues
No issues known.
Alternatives considered
No alternatives considered.