Remove index for author.search_vector, which is never used

bookwyrm/migrations/0190_book_search_updates.py

@@ -0,0 +1,16 @@
+# Generated by Django 3.2.20 on 2023-11-24 17:11
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("bookwyrm", "0188_theme_loads"),
+    ]
+
+    operations = [
+        migrations.RemoveIndex(
+            model_name="author",
+            name="bookwyrm_au_search__b050a8_gin",
+        ),
+    ]

bookwyrm/models/author.py

@@ -68,8 +68,3 @@ def get_remote_id(self):
         return f"https://{DOMAIN}/author/{self.id}"
 
     activity_serializer = activitypub.Author
-
-    class Meta:
-        """sets up postgres GIN index field"""
-
-        indexes = (GinIndex(fields=["search_vector"]),)

bookwyrm/tests/test_book_search.py

@@ -156,21 +156,21 @@ def setUp(self):
     def test_search_after_changed_metadata(self):
         """book found after updating metadata"""
         self.assertEqual(self.edition, self._search_first("First"))  # title
-        self.assertEqual(self.edition, self._search_first("Good"))   # subtitle
-        self.assertEqual(self.edition, self._search_first("Sequence")) # series
+        self.assertEqual(self.edition, self._search_first("Good"))  # subtitle
+        self.assertEqual(self.edition, self._search_first("Sequence"))  # series
 
         self.edition.title = "Second Title of Work"
         self.edition.subtitle = "Fewer Words Is Better"
         self.edition.series = "A Wondrous Bunch"
         self.edition.save(broadcast=False)
 
-        self.assertEqual(self.edition, self._search_first("Second")) # title new
+        self.assertEqual(self.edition, self._search_first("Second"))  # title new
         self.assertEqual(self.edition, self._search_first("Fewer"))  # subtitle new
-        self.assertEqual(self.edition, self._search_first("Wondrous")) # series new
+        self.assertEqual(self.edition, self._search_first("Wondrous"))  # series new
 
         self.assertFalse(self._search_first("First"))  # title old
-        self.assertFalse(self._search_first("Good"))   # subtitle old
-        self.assertFalse(self._search_first("Sequence")) # series old
+        self.assertFalse(self._search_first("Good"))  # subtitle old
+        self.assertFalse(self._search_first("Sequence"))  # series old
 
     def test_search_after_author_remove(self):
         """book not found via removed author"""
@@ -211,6 +211,7 @@ def _search_first(self, query):
         """wrapper around search_title_author"""
         return self._search(query, return_first=True)
 
+    # pylint: disable-next=no-self-use
     def _search(self, query, *, return_first=False):
         """wrapper around search_title_author"""
         return book_search.search_title_author(